sunvdc: limit each sg segment to a page
authorDwight Engen <dwight.engen@oracle.com>
Fri, 19 Sep 2014 13:42:53 +0000 (09:42 -0400)
committerDavid S. Miller <davem@davemloft.net>
Tue, 30 Sep 2014 21:37:35 +0000 (14:37 -0700)
ldc_map_sg() could fail its check that the number of pages referred to
by the sg scatterlist was <= the number of cookies.

This fixes the issue by doing a similar thing to the xen-blkfront driver,
ensuring that the scatterlist will only ever contain a segment count <=
port->ring_cookies, and each segment will be page aligned, and <= page
size. This ensures that the scatterlist is always mappable.

Orabug: 19347817
OraBZ: 15945

Signed-off-by: Dwight Engen <dwight.engen@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/block/sunvdc.c

index 1616ad091a5ed513316e7e348167194bc792806a..1a9360da1f546f4acbc5df1ca337572f65993616 100644 (file)
@@ -747,6 +747,10 @@ static int probe_disk(struct vdc_port *port)
 
        port->disk = g;
 
+       /* Each segment in a request is up to an aligned page in size. */
+       blk_queue_segment_boundary(q, PAGE_SIZE - 1);
+       blk_queue_max_segment_size(q, PAGE_SIZE);
+
        blk_queue_max_segments(q, port->ring_cookies);
        blk_queue_max_hw_sectors(q, port->max_xfer_size);
        g->major = vdc_major;