Remove unneeded include paths in PLAT_INCLUDES

Also, update platform_def.h guidelines about includes in the porting
guide.

Change-Id: I1ae338c9dd3242b309f6d53687ba2cb755d488c3
Signed-off-by: Antonio Nino Diaz <antonio.ninodiaz@arm.com>

diff --git a/docs/porting-guide.rst b/docs/porting-guide.rst
index 7fc529708c5fca370e82f27c987a5aff82d54a03..30a863d5f473b5e06c4609dc00fce5018fd11b9b 100644 (file)
--- a/docs/porting-guide.rst
+++ b/docs/porting-guide.rst
@@ -103,20 +103,13 @@ File : platform\_def.h [mandatory]
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
 Each platform must ensure that a header file of this name is in the system
-include path with the following constants defined. This may require updating the
-list of ``PLAT_INCLUDES`` in the ``platform.mk`` file. In the Arm development
-platforms, this file is found in ``plat/arm/board/<plat_name>/include/``.
+include path with the following constants defined. This will require updating
+the list of ``PLAT_INCLUDES`` in the ``platform.mk`` file.
 
 Platform ports may optionally use the file `include/plat/common/common\_def.h`_,
 which provides typical values for some of the constants below. These values are
 likely to be suitable for all platform ports.
 
-Platform ports that want to be aligned with standard Arm platforms (for example
-FVP and Juno) may also use `include/plat/arm/common/arm\_def.h`_, which provides
-standard values for some of the constants below. However, this requires the
-platform port to define additional platform porting constants in
-``platform_def.h``. These additional constants are not documented here.
-
 -  **#define : PLATFORM\_LINKER\_FORMAT**
 
    Defines the linker format used by the platform, for example

diff --git a/plat/hisilicon/hikey/platform.mk b/plat/hisilicon/hikey/platform.mk
index 6d077f746428fcabb5942a200bd5e40e20ce353e..99887eeef85b136fe28ca94b89aee8ce77cba6da 100644 (file)
--- a/plat/hisilicon/hikey/platform.mk
+++ b/plat/hisilicon/hikey/platform.mk
@@ -45,8 +45,7 @@ endif
 
 USE_COHERENT_MEM       :=      1
 
-PLAT_INCLUDES          :=      -Iinclude/common/tbbr                   \
-                               -Iplat/hisilicon/hikey/include
+PLAT_INCLUDES          :=      -Iplat/hisilicon/hikey/include
 
 PLAT_BL_COMMON_SOURCES :=      drivers/arm/pl011/aarch64/pl011_console.S \
                                lib/xlat_tables/aarch64/xlat_tables.c   \

diff --git a/plat/hisilicon/hikey960/platform.mk b/plat/hisilicon/hikey960/platform.mk
index ff008e77a08adfb095c172befec7f9b155c26002..8ff303fdc86211042c5cc16e2b17004271baddff 100644 (file)
--- a/plat/hisilicon/hikey960/platform.mk
+++ b/plat/hisilicon/hikey960/platform.mk
@@ -40,8 +40,7 @@ endif
 
 USE_COHERENT_MEM       :=      1
 
-PLAT_INCLUDES          :=      -Iinclude/common/tbbr                   \
-                               -Iplat/hisilicon/hikey960/include
+PLAT_INCLUDES          :=      -Iplat/hisilicon/hikey960/include
 
 PLAT_BL_COMMON_SOURCES :=      drivers/arm/pl011/aarch64/pl011_console.S \
                                drivers/delay_timer/delay_timer.c       \

diff --git a/plat/hisilicon/poplar/platform.mk b/plat/hisilicon/poplar/platform.mk
index eca14125e15588d12a0150b507327617291503b5..a1535a4d4b851e241bd82ff3ca9bf21fda16e7ba 100644 (file)
--- a/plat/hisilicon/poplar/platform.mk
+++ b/plat/hisilicon/poplar/platform.mk
@@ -53,8 +53,7 @@ PLAT_PL061_MAX_GPIOS          := 104
 $(eval $(call add_define,PLAT_PL061_MAX_GPIOS))
 
 PLAT_INCLUDES  :=      -Iplat/hisilicon/poplar/include         \
-                       -Iplat/hisilicon/poplar                 \
-                       -Iinclude/common/tbbr
+                       -Iplat/hisilicon/poplar
 
 PLAT_BL_COMMON_SOURCES :=                                              \
                lib/xlat_tables/aarch64/xlat_tables.c                   \

diff --git a/plat/imx/imx7/warp7/platform.mk b/plat/imx/imx7/warp7/platform.mk
index f7bd4ae5ba153d046b48e49fb7b2327ff14ccf94..f29f7799a7b80f2e5d64259b87c2d1410f72e6fd 100644 (file)
--- a/plat/imx/imx7/warp7/platform.mk
+++ b/plat/imx/imx7/warp7/platform.mk
@@ -21,7 +21,6 @@ endif
 
 # Platform
 PLAT_INCLUDES          :=      -Idrivers/imx/uart                      \
-                               -Iinclude/common/tbbr                   \
                                -Iplat/imx/common/include/              \
                                -Iplat/imx/imx7/warp7/include           \
                                -Idrivers/imx/timer                     \

diff --git a/plat/layerscape/board/ls1043/platform.mk b/plat/layerscape/board/ls1043/platform.mk
index 91a14a445ced300a50b4ebc8e5960d83f06cddf4..2e0e59bd5c34bdc5cf06c8f9799603231b14085d 100644 (file)
--- a/plat/layerscape/board/ls1043/platform.mk
+++ b/plat/layerscape/board/ls1043/platform.mk
@@ -23,8 +23,6 @@ LS1043_SECURITY_SOURCES       :=      plat/layerscape/common/ls_tzc380.c      \
 
 PLAT_INCLUDES                  :=      -Iplat/layerscape/board/ls1043/include   \
                                        -Iplat/layerscape/common/include        \
-                                       -Iinclude/lib
-
 
 PLAT_BL_COMMON_SOURCES         :=      plat/layerscape/common/aarch64/ls_console.S
 

diff --git a/plat/layerscape/common/ls_common.mk b/plat/layerscape/common/ls_common.mk
index 5d96aed1ce877e6487e1d6b520d5a3155da20b36..39867e6dbb4f22cff8b1ffc4ef5d1ecd602a1dd6 100644 (file)
--- a/plat/layerscape/common/ls_common.mk
+++ b/plat/layerscape/common/ls_common.mk
@@ -15,8 +15,6 @@ SEPARATE_CODE_AND_RODATA      :=      1
 
 COLD_BOOT_SINGLE_CPU           :=      1
 
-PLAT_INCLUDES          +=      -Iinclude/common/tbbr
-
 PLAT_BL_COMMON_SOURCES +=      plat/layerscape/common/${ARCH}/ls_helpers.S             \
                                plat/layerscape/common/ls_common.c
 

diff --git a/plat/marvell/a3700/common/a3700_common.mk b/plat/marvell/a3700/common/a3700_common.mk
index a4727d2ea74a7bae846f7a552ab14a2a3f002157..64cd43344e79c0858b56cc2718cb36505c5b362a 100644 (file)
--- a/plat/marvell/a3700/common/a3700_common.mk
+++ b/plat/marvell/a3700/common/a3700_common.mk
@@ -84,14 +84,11 @@ MARVELL_GIC_SOURCES :=      drivers/arm/gic/common/gic_common.c     \
                                plat/common/plat_gicv3.c                \
                                drivers/arm/gic/v3/gic500.c
 
-ATF_INCLUDES           :=      -Iinclude/common/tbbr
-
 PLAT_INCLUDES          :=      -I$(PLAT_FAMILY_BASE)/$(PLAT)           \
                                -I$(PLAT_COMMON_BASE)/include           \
                                -I$(PLAT_INCLUDE_BASE)/common           \
                                -I$(MARVELL_DRV_BASE)                   \
-                               -I$/drivers/arm/gic/common/             \
-                               $(ATF_INCLUDES)
+                               -I$/drivers/arm/gic/common/
 
 PLAT_BL_COMMON_SOURCES :=      $(PLAT_COMMON_BASE)/aarch64/a3700_common.c \
                                $(MARVELL_COMMON_BASE)/marvell_cci.c       \

diff --git a/plat/marvell/a8k/common/a8k_common.mk b/plat/marvell/a8k/common/a8k_common.mk
index efb05b8e24269168ebcf4f7886b412e4a11fc34a..ccb662bb2ce0cd415937cc9521f240773fca74f6 100644 (file)
--- a/plat/marvell/a8k/common/a8k_common.mk
+++ b/plat/marvell/a8k/common/a8k_common.mk
@@ -45,12 +45,9 @@ MARVELL_GIC_SOURCES  :=      drivers/arm/gic/common/gic_common.c     \
                                drivers/arm/gic/v2/gicv2_helpers.c      \
                                plat/common/plat_gicv2.c
 
-ATF_INCLUDES           :=      -Iinclude/common/tbbr
-
 PLAT_INCLUDES          :=      -I$(PLAT_FAMILY_BASE)/$(PLAT)           \
                                -I$(PLAT_COMMON_BASE)/include           \
-                               -I$(PLAT_INCLUDE_BASE)/common           \
-                               $(ATF_INCLUDES)
+                               -I$(PLAT_INCLUDE_BASE)/common
 
 PLAT_BL_COMMON_SOURCES :=      $(PLAT_COMMON_BASE)/aarch64/a8k_common.c \
                                drivers/ti/uart/aarch64/16550_console.S

diff --git a/plat/marvell/a8k/common/ble/ble.mk b/plat/marvell/a8k/common/ble/ble.mk
index ed4ff3af293606c0c282464bb3e46bfdb87afa64..b24083fc38267ba2c3873e93983d1b41af305754 100644 (file)
--- a/plat/marvell/a8k/common/ble/ble.mk
+++ b/plat/marvell/a8k/common/ble/ble.mk
@@ -17,11 +17,10 @@ BLE_SOURCES         +=      $(BLE_PATH)/ble_main.c                          \
                                $(PLAT_MARVELL)/common/plat_delay_timer.c       \
                                $(PLAT_MARVELL)/common/marvell_console.c
 
-PLAT_INCLUDES          +=      -I$(MV_DDR_PATH) \
-                               -I$(CURDIR)/include/ \
-                               -I$(CURDIR)/include/lib \
-                               -I$(CURDIR)/include/lib/libc \
-                               -I$(CURDIR)/include/lib/libc/aarch64 \
+PLAT_INCLUDES          +=      -I$(MV_DDR_PATH)                                \
+                               -I$(CURDIR)/include                             \
+                               -I$(CURDIR)/include/lib/libc                    \
+                               -I$(CURDIR)/include/lib/libc/aarch64            \
                                -I$(CURDIR)/drivers/marvell
 
 BLE_LINKERFILE         :=      $(BLE_PATH)/ble.ld.S

diff --git a/plat/marvell/common/marvell_common.mk b/plat/marvell/common/marvell_common.mk
index fb6fbb5859b8751fa7e4ad5f5868ea3ffaf438f3..a1282619582faafae4ce398da2c9d1d75746c8fc 100644 (file)
--- a/plat/marvell/common/marvell_common.mk
+++ b/plat/marvell/common/marvell_common.mk
@@ -22,8 +22,7 @@ $(eval $(call add_define,ARO_ENABLE))
 LLC_ENABLE                     := 1
 $(eval $(call add_define,LLC_ENABLE))
 
-PLAT_INCLUDES          +=      -I. -Iinclude/common -Iinclude/common/tbbr      \
-                               -I$(MARVELL_PLAT_INCLUDE_BASE)/common   \
+PLAT_INCLUDES          +=      -I$(MARVELL_PLAT_INCLUDE_BASE)/common   \
                                -I$(MARVELL_PLAT_INCLUDE_BASE)/common/aarch64
 
 

diff --git a/plat/mediatek/mt6795/platform.mk b/plat/mediatek/mt6795/platform.mk
index c2fd511e66ec11358f3e326b592e0c2c8351a14d..4ab692d409de22dc337b8a80d1d8b6c8c296bf22 100644 (file)
--- a/plat/mediatek/mt6795/platform.mk
+++ b/plat/mediatek/mt6795/platform.mk
@@ -23,7 +23,6 @@ PLAT_INCLUDES         :=      -I${MTK_PLAT}/common/                           \
                                -I${MTK_PLAT_SOC}/drivers/timer/                        \
                                -I${MTK_PLAT_SOC}/include/                                      \
                                -Iinclude/plat/arm/common/                                      \
-                               -Iinclude/common/tbbr/                                  \
                                ${OEMS_INCLUDES}
 
 PLAT_BL_COMMON_SOURCES :=      lib/xlat_tables/aarch64/xlat_tables.c                   \

diff --git a/plat/qemu/platform.mk b/plat/qemu/platform.mk
index 982886a9330283b04b62aa6682f5040c0f9afbc6..f086ddc6ca5e98eb73e3e51b86a7a9fb0e908f46 100644 (file)
--- a/plat/qemu/platform.mk
+++ b/plat/qemu/platform.mk
@@ -30,9 +30,7 @@ $(eval $(call add_define,QEMU_LOAD_BL32))
 endif
 
 PLAT_PATH               :=      plat/qemu/
-PLAT_INCLUDES          :=      -Iinclude/plat/arm/common/              \
-                               -Iplat/qemu/include                     \
-                               -Iinclude/common/tbbr
+PLAT_INCLUDES          :=      -Iplat/qemu/include
 
 ifeq (${ARM_ARCH_MAJOR},8)
 PLAT_INCLUDES          +=      -Iinclude/plat/arm/common/${ARCH}
@@ -55,8 +53,6 @@ ifneq (${TRUSTED_BOARD_BOOT},0)
                                drivers/auth/img_parser_mod.c           \
                                drivers/auth/tbbr/tbbr_cot.c
 
-    PLAT_INCLUDES      +=      -Iinclude/bl1/tbbr
-
     BL1_SOURCES                +=      ${AUTH_SOURCES}                         \
                                bl1/tbbr/tbbr_img_desc.c                \
                                plat/common/tbbr/plat_tbbr.c            \

diff --git a/plat/renesas/rcar/platform.mk b/plat/renesas/rcar/platform.mk
index 629a3cf98cdd32ba726e74c13e64cbd1c2a1f110..a54a60a37133425f436def4dc8c5ee021facddd0 100644 (file)
--- a/plat/renesas/rcar/platform.mk
+++ b/plat/renesas/rcar/platform.mk
@@ -306,8 +306,7 @@ include drivers/staging/renesas/rcar/qos/qos.mk
 include drivers/staging/renesas/rcar/pfc/pfc.mk
 include lib/libfdt/libfdt.mk
 
-PLAT_INCLUDES  :=      -Iinclude/common/tbbr                   \
-                       -Idrivers/staging/renesas/rcar/ddr      \
+PLAT_INCLUDES  :=      -Idrivers/staging/renesas/rcar/ddr      \
                        -Idrivers/staging/renesas/rcar/qos      \
                        -Idrivers/renesas/rcar/iic_dvfs         \
                        -Idrivers/renesas/rcar/board            \

diff --git a/plat/rockchip/rk3328/platform.mk b/plat/rockchip/rk3328/platform.mk
index 2b2ac51c47e9a9478015c00bca5ca76841e0098d..ca6345b7ecb5814e7c981cfb21edf9d08630c754 100644 (file)
--- a/plat/rockchip/rk3328/platform.mk
+++ b/plat/rockchip/rk3328/platform.mk
@@ -10,7 +10,6 @@ RK_PLAT_COMMON                :=      ${RK_PLAT}/common
 
 PLAT_INCLUDES          :=      -Idrivers/arm/gic/common/                       \
                                -Idrivers/arm/gic/v2/                   \
-                               -Iinclude/plat/common/                          \
                                -I${RK_PLAT_COMMON}/                            \
                                -I${RK_PLAT_COMMON}/include/                    \
                                -I${RK_PLAT_COMMON}/pmusram                     \

diff --git a/plat/socionext/uniphier/platform.mk b/plat/socionext/uniphier/platform.mk
index e7a1bfe5c936e90d9151fdc1a717fa65c949533e..94c44056eac8ae00ae770d0a7586d38ea1f49950 100644 (file)
--- a/plat/socionext/uniphier/platform.mk
+++ b/plat/socionext/uniphier/platform.mk
@@ -72,8 +72,6 @@ ifeq (${TRUSTED_BOARD_BOOT},1)
 include drivers/auth/mbedtls/mbedtls_crypto.mk
 include drivers/auth/mbedtls/mbedtls_x509.mk
 
-PLAT_INCLUDES          +=      -Iinclude/common/tbbr
-
 BL2_SOURCES            +=      drivers/auth/auth_mod.c                 \
                                drivers/auth/crypto_mod.c               \
                                drivers/auth/img_parser_mod.c           \