ASoC: qdsp6: q6asm-dai: do not close port if its not opened
authorSrinivas Kandagatla <srinivas.kandagatla@linaro.org>
Wed, 4 Jul 2018 09:49:44 +0000 (10:49 +0100)
committerMark Brown <broonie@kernel.org>
Wed, 4 Jul 2018 14:34:48 +0000 (15:34 +0100)
asm ports are open as part of prepare, so for use cases like
"aplay sample.wav" were sample.wav is not present. This would
call port close eventhough port was never opened. DSP would
return errors for such use cases.

Avoid doing this by checking the port state.

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/qcom/qdsp6/q6asm-dai.c

index 349c6a883c63c76d5890c602038e3afe36c300c0..360936703b3d5357884416304e3b9a7ef1c61a7e 100644 (file)
@@ -390,7 +390,9 @@ static int q6asm_dai_close(struct snd_pcm_substream *substream)
        struct q6asm_dai_rtd *prtd = runtime->private_data;
 
        if (prtd->audio_client) {
-               q6asm_cmd(prtd->audio_client, CMD_CLOSE);
+               if (prtd->state)
+                       q6asm_cmd(prtd->audio_client, CMD_CLOSE);
+
                q6asm_unmap_memory_regions(substream->stream,
                                           prtd->audio_client);
                q6asm_audio_client_free(prtd->audio_client);