perf cgroup: Make evlist__find_cgroup() more compact
authorArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 24 May 2018 14:29:07 +0000 (11:29 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Mon, 4 Jun 2018 13:28:50 +0000 (10:28 -0300)
By taking advantage that __get() routines return the pointer to the
object for which a reference count is being get.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Wang Nan <wangnan0@huawei.com>
Link: https://lkml.kernel.org/n/tip-xnvd07rdxliy04oi062samik@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/cgroup.c

index decb91f9da82b54db7460beb182d9aa2598e18f4..ccd02634a616e76941f32b7059a7d6342f3c02f2 100644 (file)
@@ -93,20 +93,17 @@ static int open_cgroup(const char *name)
 static struct cgroup *evlist__find_cgroup(struct perf_evlist *evlist, const char *str)
 {
        struct perf_evsel *counter;
-       struct cgroup *cgrp = NULL;
        /*
         * check if cgrp is already defined, if so we reuse it
         */
        evlist__for_each_entry(evlist, counter) {
                if (!counter->cgrp)
                        continue;
-               if (!strcmp(counter->cgrp->name, str)) {
-                       cgrp = cgroup__get(counter->cgrp);
-                       break;
-               }
+               if (!strcmp(counter->cgrp->name, str))
+                       return cgroup__get(counter->cgrp);
        }
 
-       return cgrp;
+       return NULL;
 }
 
 static struct cgroup *cgroup__new(const char *name)