net: ll_temac: Improve error message on error IRQ

The channel status register value can be very helpful when debugging
SDMA problems.

Signed-off-by: Esben Haabendal <esben@geanix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
index f389a819f058f4a76510d14878624d5cbf6cbc84..997475c209c0da05d762b900a916b4ffdafad830 100644 (file)
--- a/drivers/net/ethernet/xilinx/ll_temac_main.c
+++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
@@ -886,8 +886,10 @@ static irqreturn_t ll_temac_tx_irq(int irq, void *_ndev)
 
        if (status & (IRQ_COAL | IRQ_DLY))
                temac_start_xmit_done(lp->ndev);
-       if (status & 0x080)
-               dev_err(&ndev->dev, "DMA error 0x%x\n", status);
+       if (status & (IRQ_ERR | IRQ_DMAERR))
+               dev_err_ratelimited(&ndev->dev,
+                                   "TX error 0x%x TX_CHNL_STS=0x%08x\n",
+                                   status, lp->dma_in(lp, TX_CHNL_STS));
 
        return IRQ_HANDLED;
 }
@@ -904,6 +906,10 @@ static irqreturn_t ll_temac_rx_irq(int irq, void *_ndev)
 
        if (status & (IRQ_COAL | IRQ_DLY))
                ll_temac_recv(lp->ndev);
+       if (status & (IRQ_ERR | IRQ_DMAERR))
+               dev_err_ratelimited(&ndev->dev,
+                                   "RX error 0x%x RX_CHNL_STS=0x%08x\n",
+                                   status, lp->dma_in(lp, RX_CHNL_STS));
 
        return IRQ_HANDLED;
 }