f_phonet: lock-less MTU change
authorRémi Denis-Courmont <remi.denis-courmont@nokia.com>
Thu, 6 Aug 2009 21:56:43 +0000 (21:56 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 13 Aug 2009 03:44:48 +0000 (20:44 -0700)
With the current driver, the MTU is purely indicative, so there is no
need to synchronize with the receive path.

Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/usb/gadget/f_phonet.c

index d17f1082df96351579e6facac3173fe220fc685e..f4eff7ca0d3691bb74c8236467897301f54dbb01 100644 (file)
@@ -261,20 +261,10 @@ out:
 
 static int pn_net_mtu(struct net_device *dev, int new_mtu)
 {
-       struct phonet_port *port = netdev_priv(dev);
-       unsigned long flags;
-       int err = -EBUSY;
-
        if ((new_mtu < PHONET_MIN_MTU) || (new_mtu > PHONET_MAX_MTU))
                return -EINVAL;
-
-       spin_lock_irqsave(&port->lock, flags);
-       if (!netif_carrier_ok(dev)) {
-               dev->mtu = new_mtu;
-               err = 0;
-       }
-       spin_unlock_irqrestore(&port->lock, flags);
-       return err;
+       dev->mtu = new_mtu;
+       return 0;
 }
 
 static const struct net_device_ops pn_netdev_ops = {