nl80211: Add a missing break in parse_station_flags
authorBernd Edlinger <bernd.edlinger@hotmail.de>
Sun, 8 Jul 2018 09:57:22 +0000 (09:57 +0000)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 9 Jul 2018 07:09:57 +0000 (09:09 +0200)
I was looking at usually suppressed gcc warnings,
[-Wimplicit-fallthrough=] in this case:

The code definitely looks like a break is missing here.
However I am not able to test the NL80211_IFTYPE_MESH_POINT,
nor do I actually know what might be :)
So please use this patch with caution and only if you are
able to do some testing.

Signed-off-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
[johannes: looks obvious enough to apply as is, interesting
 though that it never seems to have been a problem]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/wireless/nl80211.c

index b6c700572755143cc5775a191dc1520e625fed9e..80bc986c79e5aea8d50121be481833738a1d50b7 100644 (file)
@@ -4409,6 +4409,7 @@ static int parse_station_flags(struct genl_info *info,
                params->sta_flags_mask = BIT(NL80211_STA_FLAG_AUTHENTICATED) |
                                         BIT(NL80211_STA_FLAG_MFP) |
                                         BIT(NL80211_STA_FLAG_AUTHORIZED);
+               break;
        default:
                return -EINVAL;
        }