pinctrl: samsung: Fix device node refcount leaks in Exynos wakeup controller init

In exynos_eint_wkup_init() the for_each_child_of_node() loop is used
with a break to find a matching child node.  Although each iteration of
for_each_child_of_node puts the previous node, but early exit from loop
misses it.  This leads to leak of device node.

Cc: <stable@vger.kernel.org>
Fixes: 43b169db1841 ("pinctrl: add exynos4210 specific extensions for samsung pinctrl driver")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

diff --git a/drivers/pinctrl/samsung/pinctrl-exynos.c b/drivers/pinctrl/samsung/pinctrl-exynos.c
index e7f4cbad2c92c1a49edab9b62785eb8840d5af1d..0599f5127b010399b14215b10ab8ff64d6d8ebe9 100644 (file)
--- a/drivers/pinctrl/samsung/pinctrl-exynos.c
+++ b/drivers/pinctrl/samsung/pinctrl-exynos.c
@@ -506,6 +506,7 @@ int exynos_eint_wkup_init(struct samsung_pinctrl_drv_data *d)
                                bank->nr_pins, &exynos_eint_irqd_ops, bank);
                if (!bank->irq_domain) {
                        dev_err(dev, "wkup irq domain add failed\n");
+                       of_node_put(wkup_np);
                        return -ENXIO;
                }
 
@@ -520,8 +521,10 @@ int exynos_eint_wkup_init(struct samsung_pinctrl_drv_data *d)
                weint_data = devm_kcalloc(dev,
                                          bank->nr_pins, sizeof(*weint_data),
                                          GFP_KERNEL);
-               if (!weint_data)
+               if (!weint_data) {
+                       of_node_put(wkup_np);
                        return -ENOMEM;
+               }
 
                for (idx = 0; idx < bank->nr_pins; ++idx) {
                        irq = irq_of_parse_and_map(bank->of_node, idx);
@@ -538,10 +541,13 @@ int exynos_eint_wkup_init(struct samsung_pinctrl_drv_data *d)
                }
        }
 
-       if (!muxed_banks)
+       if (!muxed_banks) {
+               of_node_put(wkup_np);
                return 0;
+       }
 
        irq = irq_of_parse_and_map(wkup_np, 0);
+       of_node_put(wkup_np);
        if (!irq) {
                dev_err(dev, "irq number for muxed EINTs not found\n");
                return 0;