ALSA: trident: Deletion of a check before snd_util_memhdr_free()
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 2 Dec 2014 17:52:21 +0000 (18:52 +0100)
committerTakashi Iwai <tiwai@suse.de>
Tue, 2 Dec 2014 19:10:42 +0000 (20:10 +0100)
The snd_util_memhdr_free() function tests whether its argument is NULL
and then returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/trident/trident_main.c

index da875dced2ef3559d154e63f9cdfcf26d58fc75e..57cd757acfe7a96cb92aadc48e5ffbfaaaa56533 100644 (file)
@@ -3702,8 +3702,7 @@ static int snd_trident_free(struct snd_trident *trident)
                free_irq(trident->irq, trident);
        if (trident->tlb.buffer.area) {
                outl(0, TRID_REG(trident, NX_TLBC));
-               if (trident->tlb.memhdr)
-                       snd_util_memhdr_free(trident->tlb.memhdr);
+               snd_util_memhdr_free(trident->tlb.memhdr);
                if (trident->tlb.silent_page.area)
                        snd_dma_free_pages(&trident->tlb.silent_page);
                vfree(trident->tlb.shadow_entries);