mac80211: Use setup_timer instead of init_timer for mesh path
authorOndřej Lysoněk <ondrej.lysonek@seznam.cz>
Thu, 9 Mar 2017 09:34:36 +0000 (10:34 +0100)
committerJohannes Berg <johannes.berg@intel.com>
Thu, 16 Mar 2017 09:54:04 +0000 (10:54 +0100)
Use setup_timer() and setup_deferrable_timer() to set the data and
function timer fields. It makes the code cleaner and will allow for
easier change of the timer struct internals.

Signed-off-by: Ondřej Lysoněk <ondrej.lysonek@seznam.cz>
Cc: Jiri Slaby <jslaby@suse.cz>
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: <linux-wireless@vger.kernel.org>
Cc: <netdev@vger.kernel.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/mesh_pathtbl.c

index 98a3b1c0c3385cea00cecea740ee4e027bbe8ddf..97269caafecd7b52e644e9bb645d305fdfb67196 100644 (file)
@@ -397,11 +397,10 @@ struct mesh_path *mesh_path_new(struct ieee80211_sub_if_data *sdata,
        new_mpath->sdata = sdata;
        new_mpath->flags = 0;
        skb_queue_head_init(&new_mpath->frame_queue);
-       new_mpath->timer.data = (unsigned long) new_mpath;
-       new_mpath->timer.function = mesh_path_timer;
        new_mpath->exp_time = jiffies;
        spin_lock_init(&new_mpath->state_lock);
-       init_timer(&new_mpath->timer);
+       setup_timer(&new_mpath->timer, mesh_path_timer,
+                   (unsigned long) new_mpath);
 
        return new_mpath;
 }