decnet: Remove unnecessary check for dev->name
authorNathan Chancellor <natechancellor@gmail.com>
Fri, 21 Sep 2018 19:30:34 +0000 (12:30 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 22 Sep 2018 02:48:36 +0000 (19:48 -0700)
Clang warns that the address of a pointer will always evaluated as true
in a boolean context.

net/decnet/dn_dev.c:1366:10: warning: address of array 'dev->name' will
always evaluate to 'true' [-Wpointer-bool-conversion]
                                dev->name ? dev->name : "???",
                                ~~~~~^~~~ ~
1 warning generated.

Link: https://github.com/ClangBuiltLinux/linux/issues/116
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/decnet/dn_dev.c

index bfd43e8f2c06e8c1c8e69d8ce95a349734166584..d0b3e69c6b39ba2f051f128dc1e0daa44291fc77 100644 (file)
@@ -1363,7 +1363,7 @@ static int dn_dev_seq_show(struct seq_file *seq, void *v)
 
                seq_printf(seq, "%-8s %1s     %04u %04u   %04lu %04lu"
                                "   %04hu    %03d %02x    %-10s %-7s %-7s\n",
-                               dev->name ? dev->name : "???",
+                               dev->name,
                                dn_type2asc(dn_db->parms.mode),
                                0, 0,
                                dn_db->t3, dn_db->parms.t3,