qlcnic: use the correct ring in qlcnic_83xx_process_rcv_ring_diag()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 27 Jun 2016 20:50:29 +0000 (23:50 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 29 Jun 2016 09:46:16 +0000 (05:46 -0400)
There is a static checker warning here "warn: mask and shift to zero"
and the code sets "ring" to zero every time.  From looking at how
QLCNIC_FETCH_RING_ID() is used in qlcnic_83xx_process_rcv_ring() the
qlcnic_83xx_hndl() should be removed.

Fixes: 4be41e92f7c6 ('qlcnic: 83xx data path routines')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c

index 7bd6f25b4625f3bd634f9ac519127edca0a4fbce..607bb7d4514d83b3e4de32f7a8abe634f81a5d95 100644 (file)
@@ -2220,7 +2220,7 @@ void qlcnic_83xx_process_rcv_ring_diag(struct qlcnic_host_sds_ring *sds_ring)
        if (!opcode)
                return;
 
-       ring = QLCNIC_FETCH_RING_ID(qlcnic_83xx_hndl(sts_data[0]));
+       ring = QLCNIC_FETCH_RING_ID(sts_data[0]);
        qlcnic_83xx_process_rcv_diag(adapter, ring, sts_data);
        desc = &sds_ring->desc_head[consumer];
        desc->status_desc_data[0] = cpu_to_le64(STATUS_OWNER_PHANTOM);