ag71xx: Slightly simplify 'ag71xx_rx_packets()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Wed, 13 Mar 2024 22:39:23 +0000 (15:39 -0700)
committerChristian Marangi <ansuelsmth@gmail.com>
Tue, 14 May 2024 10:21:02 +0000 (12:21 +0200)
There is no need to use 'list_for_each_entry_safe' here, as nothing is
removed from the list in the 'for' loop.
Use 'list_for_each_entry' instead, it is slightly less verbose.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://github.com/openwrt/openwrt/pull/15435
Link: https://github.com/openwrt/openwrt/pull/15435
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
target/linux/ath79/files/drivers/net/ethernet/atheros/ag71xx/ag71xx_main.c

index 8132849a9ae12d13628b449701c5a27f8249f0ae..8f2a9c772321ac819e8843acb54a4c38f90162e6 100644 (file)
@@ -1319,7 +1319,6 @@ static int ag71xx_rx_packets(struct ag71xx *ag, int limit)
        int ring_mask = BIT(ring->order) - 1;
        int ring_size = BIT(ring->order);
        struct list_head rx_list;
-       struct sk_buff *next;
        struct sk_buff *skb;
        int done = 0;
 
@@ -1379,7 +1378,7 @@ next:
 
        ag71xx_ring_rx_refill(ag);
 
-       list_for_each_entry_safe(skb, next, &rx_list, list)
+       list_for_each_entry(skb, &rx_list, list)
                skb->protocol = eth_type_trans(skb, dev);
        netif_receive_skb_list(&rx_list);