cpufreq: intel_pstate: Simplify intel_pstate_cpu_init()
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 25 Mar 2020 15:18:09 +0000 (16:18 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 26 Mar 2020 19:30:11 +0000 (20:30 +0100)
The initial policy value set by intel_pstate_cpu_init() depends on
whether or not CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE is set, but
that is not necessary, because the core will set the policy to
"performance" in cpufreq_init_policy() if the default governor is
"performance" anyway.

Accordingly, change intel_pstate_cpu_init() to always set policy
to CPUFREQ_POLICY_POWERSAVE initially to provide a valid fallback
value to cpufreq_init_policy() in case the default cpufreq governor
is neither "powersave" nor "performance".

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/intel_pstate.c

index 404982d655e24e4f16cfcf1de1239c20cae0a785..d2297839374d9cd0513c7aee8117b9aa111a0254 100644 (file)
@@ -2247,10 +2247,11 @@ static int intel_pstate_cpu_init(struct cpufreq_policy *policy)
        if (ret)
                return ret;
 
-       if (IS_ENABLED(CONFIG_CPU_FREQ_DEFAULT_GOV_PERFORMANCE))
-               policy->policy = CPUFREQ_POLICY_PERFORMANCE;
-       else
-               policy->policy = CPUFREQ_POLICY_POWERSAVE;
+       /*
+        * Set the policy to powersave to provide a valid fallback value in case
+        * the default cpufreq governor is neither powersave nor performance.
+        */
+       policy->policy = CPUFREQ_POLICY_POWERSAVE;
 
        return 0;
 }