nfc: nci: hci: Add check on skb nci_hci_send_cmd parameter
authorChristophe Ricard <christophe.ricard@gmail.com>
Wed, 19 Aug 2015 19:26:42 +0000 (21:26 +0200)
committerSamuel Ortiz <sameo@linux.intel.com>
Thu, 20 Aug 2015 19:56:36 +0000 (21:56 +0200)
skb can be NULL and may lead to a NULL pointer error.

Add a check condition before setting HCI rx buffer.

Cc: stable@vger.kernel.org
Signed-off-by: Christophe Ricard <christophe-h.ricard@st.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
net/nfc/nci/hci.c

index af002df640c7fa15eb412f718bb5508589429f5c..609f92283d1b74d118eb00d0fcedd6ece105e844 100644 (file)
@@ -233,7 +233,7 @@ int nci_hci_send_cmd(struct nci_dev *ndev, u8 gate, u8 cmd,
        r = nci_request(ndev, nci_hci_send_data_req, (unsigned long)&data,
                        msecs_to_jiffies(NCI_DATA_TIMEOUT));
 
-       if (r == NCI_STATUS_OK)
+       if (r == NCI_STATUS_OK && skb)
                *skb = conn_info->rx_skb;
 
        return r;