staging: pi433: Replace printk() with dev_dbg()
authorHaneen Mohammed <hamohammed.sa@gmail.com>
Tue, 12 Sep 2017 19:04:50 +0000 (13:04 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 17 Sep 2017 14:35:27 +0000 (16:35 +0200)
This patch convert printk() to the preferred variant dev_dbg() and
remove unnecessary comment line.
Issue detected with checkpatch.pl.

Signed-off-by: Haneen Mohammed <hamohammed.sa@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/pi433/pi433_if.c

index 73aa4698dfcede71964061d332b3a183a5b4cc6d..d82c74db9b6cdf64fbd1567f91a131d7814bdd3e 100644 (file)
@@ -136,17 +136,17 @@ static irqreturn_t DIO0_irq_handler(int irq, void *dev_id)
        if      (device->irq_state[DIO0] == DIO_PacketSent)
        {
                device->free_in_fifo = FIFO_SIZE;
-               printk("DIO0 irq: Packet sent\n"); // TODO: printk() should include KERN_ facility level
+               dev_dbg(device->dev, "DIO0 irq: Packet sent\n");
                wake_up_interruptible(&device->fifo_wait_queue);
        }
        else if (device->irq_state[DIO0] == DIO_Rssi_DIO0)
        {
-               printk("DIO0 irq: RSSI level over threshold\n");
+               dev_dbg(device->dev, "DIO0 irq: RSSI level over threshold\n");
                wake_up_interruptible(&device->rx_wait_queue);
        }
        else if (device->irq_state[DIO0] == DIO_PayloadReady)
        {
-               printk("DIO0 irq: PayloadReady\n");
+               dev_dbg(device->dev, "DIO0 irq: PayloadReady\n");
                device->free_in_fifo = 0;
                wake_up_interruptible(&device->fifo_wait_queue);
        }
@@ -167,7 +167,8 @@ static irqreturn_t DIO1_irq_handler(int irq, void *dev_id)
                if (device->rx_active)  device->free_in_fifo = FIFO_THRESHOLD - 1;
                else                    device->free_in_fifo = FIFO_SIZE - FIFO_THRESHOLD - 1;
        }
-       printk("DIO1 irq: %d bytes free in fifo\n", device->free_in_fifo); // TODO: printk() should include KERN_ facility level
+       dev_dbg(device->dev,
+               "DIO1 irq: %d bytes free in fifo\n", device->free_in_fifo);
        wake_up_interruptible(&device->fifo_wait_queue);
 
        return IRQ_HANDLED;