PCI: Mark expected switch fall-through
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Fri, 2 Aug 2019 01:22:48 +0000 (20:22 -0500)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 8 Aug 2019 20:13:34 +0000 (15:13 -0500)
Mark switch cases where we are expecting to fall through.

This fixes the following warning (Building: allmodconfig i386):

  drivers/pci/hotplug/ibmphp_res.c: In function ‘update_bridge_ranges’:
  drivers/pci/hotplug/ibmphp_res.c:1943:16: warning: this statement may fall through [-Wimplicit-fallthrough=]
 function = 0x8;
 ~~~~~~~~~^~~~~
  drivers/pci/hotplug/ibmphp_res.c:1944:6: note: here
case PCI_HEADER_TYPE_MULTIBRIDGE:
^~~~

Link: https://lore.kernel.org/r/20190802012248.GA22622@embeddedor
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
drivers/pci/hotplug/ibmphp_res.c

index 5e8caf7a4452b2e2df2f4c9f23a5547979327200..5c93aa14f0de21ff008345037b2307fbeb7c3ed7 100644 (file)
@@ -1941,6 +1941,7 @@ static int __init update_bridge_ranges(struct bus_node **bus)
                                                break;
                                        case PCI_HEADER_TYPE_BRIDGE:
                                                function = 0x8;
+                                               /* fall through */
                                        case PCI_HEADER_TYPE_MULTIBRIDGE:
                                                /* We assume here that only 1 bus behind the bridge
                                                   TO DO: add functionality for several: