kernel: ltq-ptm: do not write directly to dev->addr
authorAleksander Jan Bajkowski <olek2@wp.pl>
Sat, 6 May 2023 21:14:16 +0000 (23:14 +0200)
committerChristian Marangi <ansuelsmth@gmail.com>
Tue, 6 Jun 2023 18:10:34 +0000 (20:10 +0200)
One is never to write to dev->addr directly. In 6.1 it will be a const and
with the newly enabled WERROR, we get a failing grade.

Lets fix this ahead of time.

Ref: https://github.com/torvalds/linux/commit/adeef3e32146a8d2a73c399dc6f5d76a449131b1
Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
package/kernel/lantiq/ltq-ptm/src/ifxmips_ptm_vdsl.c

index 1007e74cec405f6871b25a68b003b9f1bdd85113..dfb57787b9685b9280b89a64de7a71cd308c44b5 100644 (file)
@@ -146,6 +146,8 @@ unsigned int ifx_ptm_dbg_enable = DBG_ENABLE_MASK_ERR;
 
 static void ptm_setup(struct net_device *dev, int ndev)
 {
+    u8 addr[ETH_ALEN];
+
     netif_carrier_off(dev);
 
     dev->netdev_ops      = &g_ptm_netdev_ops;
@@ -154,12 +156,13 @@ static void ptm_setup(struct net_device *dev, int ndev)
     netif_napi_add(dev, &g_ptm_priv_data.itf[ndev].napi, ptm_napi_poll, 16);
     dev->watchdog_timeo  = ETH_WATCHDOG_TIMEOUT;
 
-    dev->dev_addr[0] = 0x00;
-    dev->dev_addr[1] = 0x20;
-       dev->dev_addr[2] = 0xda;
-       dev->dev_addr[3] = 0x86;
-       dev->dev_addr[4] = 0x23;
-       dev->dev_addr[5] = 0x75 + ndev;
+    addr[0] = 0x00;
+    addr[1] = 0x20;
+    addr[2] = 0xda;
+    addr[3] = 0x86;
+    addr[4] = 0x23;
+    addr[5] = 0x75 + ndev;
+    eth_hw_addr_set(dev, addr);
 }
 
 static struct net_device_stats *ptm_get_stats(struct net_device *dev)