ASoC: omap: mcbsp: Remove redundant checks for the st_data pointer
authorPeter Ujfalusi <peter.ujfalusi@ti.com>
Thu, 23 Feb 2012 13:40:55 +0000 (15:40 +0200)
committerLiam Girdwood <lrg@ti.com>
Mon, 12 Mar 2012 13:34:23 +0000 (13:34 +0000)
The parent functions of omap_st_start/stop also checks the validity of the
st_data pointer so we do not need to do it again inside of omap_st_start/stop

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
Signed-off-by: Liam Girdwood <lrg@ti.com>
sound/soc/omap/mcbsp.c

index 79f6da6381af4322c81e19572c67a0bf5b151295..5f6c21d4b59bcd7b3ba261668ce598b8e83c984e 100644 (file)
@@ -318,7 +318,7 @@ static int omap_st_start(struct omap_mcbsp *mcbsp)
 {
        struct omap_mcbsp_st_data *st_data = mcbsp->st_data;
 
-       if (st_data && st_data->enabled && !st_data->running) {
+       if (st_data->enabled && !st_data->running) {
                omap_st_fir_write(mcbsp, st_data->taps);
                omap_st_chgain(mcbsp);
 
@@ -350,7 +350,7 @@ static int omap_st_stop(struct omap_mcbsp *mcbsp)
 {
        struct omap_mcbsp_st_data *st_data = mcbsp->st_data;
 
-       if (st_data && st_data->running) {
+       if (st_data->running) {
                if (!mcbsp->free) {
                        omap_st_off(mcbsp);
                        st_data->running = 0;