bpf: re-fix skip write only files in debugfs
authorDaniel Borkmann <daniel@iogearbox.net>
Mon, 4 Nov 2019 14:27:02 +0000 (15:27 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 4 Nov 2019 19:34:34 +0000 (11:34 -0800)
Commit 5bc60de50dfe ("selftests: bpf: Don't try to read files without
read permission") got reverted as the fix was not working as expected
and real fix came in via 8101e069418d ("selftests: bpf: Skip write
only files in debugfs"). When bpf-next got merged into net-next, the
test_offload.py had a small conflict. Fix the resolution in ae8a76fb8b5d
iby not reintroducing 5bc60de50dfe again.

Fixes: ae8a76fb8b5d ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: Alexei Starovoitov <ast@kernel.org>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
tools/testing/selftests/bpf/test_offload.py

index fc8a4319c1b28a280d0f8adf913b8f2785f161d7..1afa22c88e42a85e49a299eb1e0ff72f8fbbae3d 100755 (executable)
@@ -314,7 +314,10 @@ class DebugfsDir:
                 continue
 
             p = os.path.join(path, f)
-            if os.path.isfile(p) and os.access(p, os.R_OK):
+            if not os.stat(p).st_mode & stat.S_IRUSR:
+                continue
+
+            if os.path.isfile(p):
                 _, out = cmd('cat %s/%s' % (path, f))
                 dfs[f] = out.strip()
             elif os.path.isdir(p):