cs89x0: Always report failure to request interrupt
authorMark Brown <broonie@opensource.wolfsonmicro.com>
Thu, 7 Jan 2010 08:53:05 +0000 (00:53 -0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 7 Jan 2010 09:07:29 +0000 (01:07 -0800)
A failure on request_irq() is always fatal but unlike other fatal
errors it's only reported to the user if net_debug is set. Make the
diagnostic unconditional and raise the priority so that errors are
more obvious to the user.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/cs89x0.c

index af9321617ce457bd0d42ba7d447ee3af39f7f07f..0e79cef95c0a6fd14aaa60d0233c28ba2a2e6871 100644 (file)
@@ -1325,8 +1325,7 @@ net_open(struct net_device *dev)
                write_irq(dev, lp->chip_type, dev->irq);
                ret = request_irq(dev->irq, net_interrupt, 0, dev->name, dev);
                if (ret) {
-                       if (net_debug)
-                               printk(KERN_DEBUG "cs89x0: request_irq(%d) failed\n", dev->irq);
+                       printk(KERN_ERR "cs89x0: request_irq(%d) failed\n", dev->irq);
                        goto bad_out;
                }
        }