drm/amd/display: Small comment on dc_commit_planes_to_stream
authorHarry Wentland <harry.wentland@amd.com>
Tue, 17 Oct 2017 00:10:00 +0000 (20:10 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Sat, 21 Oct 2017 20:52:37 +0000 (16:52 -0400)
Having one struct on the stack was somewhat confusing. Also mention
that the whole function should eventually go.

Signed-off-by: Harry Wentland <harry.wentland@amd.com>
Reviewed-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/core/dc.c

index 7a0593d4ca62f9090de8b4da893951b9c230e536..a71392ffc46d5cdf02f1a6a9c837fd115e589dcf 100644 (file)
@@ -918,6 +918,12 @@ bool dc_post_update_surfaces_to_stream(struct dc *dc)
        return true;
 }
 
+/*
+ * TODO this whole function needs to go
+ *
+ * dc_surface_update is needlessly complex. See if we can just replace this
+ * with a dc_plane_state and follow the atomic model a bit more closely here.
+ */
 bool dc_commit_planes_to_stream(
                struct dc *dc,
                struct dc_plane_state **plane_states,
@@ -925,6 +931,7 @@ bool dc_commit_planes_to_stream(
                struct dc_stream_state *dc_stream,
                struct dc_state *state)
 {
+       /* no need to dynamically allocate this. it's pretty small */
        struct dc_surface_update updates[MAX_SURFACES];
        struct dc_flip_addrs *flip_addr;
        struct dc_plane_info *plane_info;