[media] saa7134: fix detection of external decoders
authorMauro Carvalho Chehab <mchehab@osg.samsung.com>
Fri, 19 Feb 2016 17:03:54 +0000 (15:03 -0200)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Tue, 23 Feb 2016 10:16:06 +0000 (07:16 -0300)
As warned by smatch:
drivers/media/pci/saa7134/saa7134-core.c:840 saa7134_create_entities() info: ignoring unreachable code.
drivers/media/pci/saa7134/saa7134-core.c:843 saa7134_create_entities() warn: curly braces intended?

Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/pci/saa7134/saa7134-core.c

index 42bc4172febd0bbe974422c43391d9e6767e2972..8f3ba407713033705ef0ed18c2c04829a19f999c 100644 (file)
@@ -838,9 +838,10 @@ static void saa7134_create_entities(struct saa7134_dev *dev)
 
        /* Check if it is using an external analog TV demod */
        media_device_for_each_entity(entity, dev->media_dev) {
-               if (entity->function == MEDIA_ENT_F_ATV_DECODER)
+               if (entity->function == MEDIA_ENT_F_ATV_DECODER) {
                        decoder = entity;
                        break;
+               }
        }
 
        /*