selftests: pmtu: Allow selection of single tests
authorStefano Brivio <sbrivio@redhat.com>
Fri, 12 Oct 2018 21:54:13 +0000 (23:54 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 16 Oct 2018 05:37:28 +0000 (22:37 -0700)
As number of tests is growing, it's quite convenient to allow
single tests to be run.

Display usage when the script is run with any invalid argument,
keep existing semantics when no arguments are passed so that
automated runs won't break.

Instead of just looping on the list of requested tests, if any,
check first that they exist, and go through them in a nested
loop to keep the existing way to display test descriptions.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
tools/testing/selftests/net/pmtu.sh

index b9cdb68df4c5f8ef4fbed88150ca0cc467ca5e85..8278a24f5ba63481668d3ad7b383d48bc3a0b3d9 100755 (executable)
@@ -641,6 +641,20 @@ test_pmtu_vti6_link_change_mtu() {
        return ${fail}
 }
 
+usage() {
+       echo
+       echo "$0 [TEST]..."
+       echo "If no TEST argument is given, all tests will be run."
+       echo
+       echo "Available tests${tests}"
+       exit 1
+}
+
+for arg do
+       # Check first that all requested tests are available before running any
+       command -v > /dev/null "test_${arg}" || { echo "=== Test ${arg} not found"; usage; }
+done
+
 trap cleanup EXIT
 
 exitcode=0
@@ -650,6 +664,13 @@ IFS="
 for t in ${tests}; do
        [ $desc -eq 0 ] && name="${t}" && desc=1 && continue || desc=0
 
+       run_this=1
+       for arg do
+               [ "${arg}" = "${name}" ] && run_this=1 && break
+               run_this=0
+       done
+       [ $run_this -eq 0 ] && continue
+
        (
                unset IFS
                eval test_${name}