bgmac: propagate error codes in bgmac_probe()
authorFlorian Fainelli <f.fainelli@gmail.com>
Mon, 13 Jan 2014 03:05:55 +0000 (19:05 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 15 Jan 2014 02:19:20 +0000 (18:19 -0800)
bgmac_mii_register() and register_netdev() both return appropriate error
codes for the failures they would encounter, propagate this error code
instead of overriding the value with -ENOTSUPP which is not the correct
error code to return.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Rafał Miłecki <zajec5@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bgmac.c

index 7f968a9b52c84200d64c6f7a35f43ad3630f606d..0297a79a38e16312c7fe24bfd7d1992b980a8f85 100644 (file)
@@ -1518,14 +1518,12 @@ static int bgmac_probe(struct bcma_device *core)
        err = bgmac_mii_register(bgmac);
        if (err) {
                bgmac_err(bgmac, "Cannot register MDIO\n");
-               err = -ENOTSUPP;
                goto err_dma_free;
        }
 
        err = register_netdev(bgmac->net_dev);
        if (err) {
                bgmac_err(bgmac, "Cannot register net device\n");
-               err = -ENOTSUPP;
                goto err_mii_unregister;
        }