be2net: call napi_disable() for all event queues
authorIvan Vecera <ivecera@redhat.com>
Tue, 26 Nov 2013 16:54:41 +0000 (17:54 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 28 Nov 2013 23:50:52 +0000 (18:50 -0500)
The recent be2net commit 6384a4d (adds a support for busy polling)
introduces a regression that results in kernel crash. It incorrectly
modified be_close() so napi_disable() is called only for the first queue.
This breaks a correct pairing of napi_enable/_disable for the rest
of event queues and causes a crash in subsequent be_open() call.

Cc: Sathya Perla <sathya.perla@emulex.com>
Cc: Subbu Seetharaman <subbu.seetharaman@emulex.com>
Cc: Ajit Khaparde <ajit.khaparde@emulex.com>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Acked-by: Ajit Khaparde <ajit.khaparde@emulex.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/emulex/benet/be_main.c

index 78a0e859760b8bc6c75e4b67ea919776a23bc674..0aec4d23eb585701ada6538f7bc765e50cb103c0 100644 (file)
@@ -2663,8 +2663,8 @@ static int be_close(struct net_device *netdev)
                        napi_disable(&eqo->napi);
                        be_disable_busy_poll(eqo);
                }
-               adapter->flags &= ~BE_FLAGS_NAPI_ENABLED;
        }
+       adapter->flags &= ~BE_FLAGS_NAPI_ENABLED;
 
        be_async_mcc_disable(adapter);