drm/amdgpu: don't grab dev->struct_mutex in pm functions
authorDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 9 Jul 2015 21:32:50 +0000 (23:32 +0200)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 17 Aug 2015 20:51:13 +0000 (16:51 -0400)
Similar to radeon, except that amdgpu doesn't even use struct_mutex to
protect anything like the shared z buffer (sane gpu architecture,
yay!). And the code already grabs the globa adev->ring_lock, so this
code can't race with itself. Which makes struct_mutex completely
redundnant. Remove it.

Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Reviewed-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c

index 25b329f4b2d9f5f27bc9c800f2b3926a669d9173..efed11509f4a2326cb5c22b68d20cac77c499705 100644 (file)
@@ -580,7 +580,6 @@ force:
                amdgpu_dpm_print_power_state(adev, adev->pm.dpm.requested_ps);
        }
 
-       mutex_lock(&adev->ddev->struct_mutex);
        mutex_lock(&adev->ring_lock);
 
        /* update whether vce is active */
@@ -628,7 +627,6 @@ force:
 
 done:
        mutex_unlock(&adev->ring_lock);
-       mutex_unlock(&adev->ddev->struct_mutex);
 }
 
 void amdgpu_dpm_enable_uvd(struct amdgpu_device *adev, bool enable)