bcache: fix mistaken sysfs entry for io_error counter
authorColy Li <colyli@suse.de>
Fri, 28 Jun 2019 11:59:43 +0000 (19:59 +0800)
committerJens Axboe <axboe@kernel.dk>
Fri, 28 Jun 2019 13:39:16 +0000 (07:39 -0600)
In bch_cached_dev_files[] from driver/md/bcache/sysfs.c, sysfs_errors is
incorrectly inserted in. The correct entry should be sysfs_io_errors.

This patch fixes the problem and now I/O errors of cached device can be
read from /sys/block/bcache<N>/bcache/io_errors.

Fixes: c7b7bd07404c5 ("bcache: add io_disable to struct cached_dev")
Signed-off-by: Coly Li <colyli@suse.de>
Cc: stable@vger.kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/md/bcache/sysfs.c

index eb678e43ac00645c5d4330b51694fede143acf7e..dddb8d4048ce02413a990528dcaac824fde27478 100644 (file)
@@ -176,7 +176,7 @@ SHOW(__bch_cached_dev)
        var_print(writeback_percent);
        sysfs_hprint(writeback_rate,
                     wb ? atomic_long_read(&dc->writeback_rate.rate) << 9 : 0);
-       sysfs_hprint(io_errors,         atomic_read(&dc->io_errors));
+       sysfs_printf(io_errors,         "%i", atomic_read(&dc->io_errors));
        sysfs_printf(io_error_limit,    "%i", dc->error_limit);
        sysfs_printf(io_disable,        "%i", dc->io_disable);
        var_print(writeback_rate_update_seconds);
@@ -463,7 +463,7 @@ static struct attribute *bch_cached_dev_files[] = {
        &sysfs_writeback_rate_p_term_inverse,
        &sysfs_writeback_rate_minimum,
        &sysfs_writeback_rate_debug,
-       &sysfs_errors,
+       &sysfs_io_errors,
        &sysfs_io_error_limit,
        &sysfs_io_disable,
        &sysfs_dirty_data,