uio: remove redundant check
authorChengguang Xu <cgxu519@gmx.com>
Sat, 19 Jan 2019 13:15:34 +0000 (21:15 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 22 Jan 2019 11:03:16 +0000 (12:03 +0100)
It is not necessary to check idev->info several times under
mutex lock, so just remove redundant check.

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/uio/uio.c

index 46e5c1c31ebe73f62b50f66c2f69975d2c26a5c7..effe72834c2f0ed7ebda0c6c1d44eed526e5191f 100644 (file)
@@ -494,7 +494,7 @@ static int uio_open(struct inode *inode, struct file *filep)
                goto err_infoopen;
        }
 
-       if (idev->info && idev->info->open)
+       if (idev->info->open)
                ret = idev->info->open(idev->info, inode);
        mutex_unlock(&idev->info_lock);
        if (ret)
@@ -635,7 +635,7 @@ static ssize_t uio_write(struct file *filep, const char __user *buf,
                goto out;
        }
 
-       if (!idev->info || !idev->info->irq) {
+       if (!idev->info->irq) {
                retval = -EIO;
                goto out;
        }