drm/i915/vlv: split DPIO init and reset
authorJesse Barnes <jbarnes@virtuousgeek.org>
Tue, 17 Dec 2013 00:34:24 +0000 (16:34 -0800)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 17 Dec 2013 08:34:17 +0000 (09:34 +0100)
We only need to init the reg offset for DPIO once, but we need to reset
DPIO at resume time and at init time.

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_display.c

index 9405340369d176c49c4344f4f7a2ddce4c1c5c2d..066fc9ddbd284fec72ce21461eef9415e0f9f4fb 100644 (file)
@@ -1372,6 +1372,15 @@ static void intel_init_dpio(struct drm_device *dev)
                   DPLL_INTEGRATED_CRI_CLK_VLV);
 
        DPIO_PHY_IOSF_PORT(DPIO_PHY0) = IOSF_PORT_DPIO;
+}
+
+static void intel_reset_dpio(struct drm_device *dev)
+{
+       struct drm_i915_private *dev_priv = dev->dev_private;
+
+       if (!IS_VALLEYVIEW(dev))
+               return;
+
        /*
         * From VLV2A0_DP_eDP_DPIO_driver_vbios_notes_10.docx -
         *  6.  De-assert cmn_reset/side_reset. Same as VLV X0.
@@ -10809,7 +10818,7 @@ void intel_modeset_init_hw(struct drm_device *dev)
 
        intel_init_clock_gating(dev);
 
-       intel_init_dpio(dev);
+       intel_reset_dpio(dev);
 
        mutex_lock(&dev->struct_mutex);
        intel_enable_gt_powersave(dev);
@@ -10872,6 +10881,7 @@ void intel_modeset_init(struct drm_device *dev)
        }
 
        intel_init_dpio(dev);
+       intel_reset_dpio(dev);
 
        intel_cpu_pll_init(dev);
        intel_shared_dpll_init(dev);