Input: atakbd - fix Atari CapsLock behaviour
authorMichael Schmitz <schmitzmic@gmail.com>
Mon, 17 Sep 2018 22:27:49 +0000 (15:27 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 18 Sep 2018 22:28:07 +0000 (15:28 -0700)
The CapsLock key on Atari keyboards is not a toggle, it does send the
normal make and break scancodes.

Drop the CapsLock toggle handling code, which did cause the CapsLock
key to merely act as a Shift key.

Tested-by: Michael Schmitz <schmitzmic@gmail.com>
Signed-off-by: Michael Schmitz <schmitzmic@gmail.com>
Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/atakbd.c

index e989574a2e203d734ef4aab5930622ca5f342217..6caee807cafabf6955053ee817c30f70571d3ef5 100644 (file)
@@ -185,14 +185,8 @@ static void atakbd_interrupt(unsigned char scancode, char down)
 
                scancode = atakbd_keycode[scancode];
 
-               if (scancode == KEY_CAPSLOCK) { /* CapsLock is a toggle switch key on Amiga */
-                       input_report_key(atakbd_dev, scancode, 1);
-                       input_report_key(atakbd_dev, scancode, 0);
-                       input_sync(atakbd_dev);
-               } else {
-                       input_report_key(atakbd_dev, scancode, down);
-                       input_sync(atakbd_dev);
-               }
+               input_report_key(atakbd_dev, scancode, down);
+               input_sync(atakbd_dev);
        } else                          /* scancodes >= 0xf3 are mouse data, most likely */
                printk(KERN_INFO "atakbd: unhandled scancode %x\n", scancode);