p54: use IEEE 802.11e defaults for initialization
authorChristian Lamparter <chunkeey@web.de>
Tue, 12 Feb 2008 13:02:06 +0000 (14:02 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 29 Feb 2008 20:37:14 +0000 (15:37 -0500)
This trival one-liner changes the QoS initialization values to match IEEE
802.11e defaults.

Signed-off-by: Christian Lamparter <chunkeey@web.de>
Acked-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/p54common.c

index 0e9f887178cef113bd43bb3051bcd7a44526a788..424de9f4d5e7d4799aceaf307bec83371d09eb29 100644 (file)
@@ -782,15 +782,9 @@ static void p54_init_vdcf(struct ieee80211_hw *dev)
 
        vdcf = (struct p54_tx_control_vdcf *) hdr->data;
 
-       /*
-        * FIXME: The default values in the spec (IEEE 802.11
-        *        7.3.2.19 Table 37) are 47, 94, 0, 0, why use
-        *        47, 94, 63, 0 here? Also, the default AIFS
-        *        values (second parameter) are 2, 2, 3, 7...
-        */
        P54_SET_QUEUE(vdcf->queue[0], 0x0002, 0x0003, 0x0007, 47);
        P54_SET_QUEUE(vdcf->queue[1], 0x0002, 0x0007, 0x000f, 94);
-       P54_SET_QUEUE(vdcf->queue[2], 0x0002, 0x000f, 0x03ff, 63);
+       P54_SET_QUEUE(vdcf->queue[2], 0x0003, 0x000f, 0x03ff, 0);
        P54_SET_QUEUE(vdcf->queue[3], 0x0007, 0x000f, 0x03ff, 0);
 }