nfsd: fix boolreturn.cocci warnings
authorFengguang Wu <fengguang.wu@intel.com>
Thu, 22 Mar 2018 05:37:20 +0000 (13:37 +0800)
committerJ. Bruce Fields <bfields@redhat.com>
Tue, 3 Apr 2018 19:08:08 +0000 (15:08 -0400)
fs/nfsd/nfs4state.c:926:8-9: WARNING: return of 0/1 in function 'nfs4_delegation_exists' with return type bool
fs/nfsd/nfs4state.c:2955:9-10: WARNING: return of 0/1 in function 'nfsd4_compound_in_session' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: 68b18f52947b ("nfsd: make nfs4_get_existing_delegation less confusing")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
[bfields: also fix -EAGAIN]
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4state.c

index a64ee08aadb29b3eded21bf37d04a4d1007cf963..fc74d6f46bd5d17a2adf89a4d2ddc80f9e5c44cd 100644 (file)
@@ -935,10 +935,10 @@ nfs4_delegation_exists(struct nfs4_client *clp, struct nfs4_file *fp)
        list_for_each_entry(searchdp, &fp->fi_delegations, dl_perfile) {
                searchclp = searchdp->dl_stid.sc_client;
                if (clp == searchclp) {
-                       return -EAGAIN;
+                       return true;
                }
        }
-       return 0;
+       return false;
 }
 
 /**
@@ -2958,7 +2958,7 @@ out_no_session:
 static bool nfsd4_compound_in_session(struct nfsd4_session *session, struct nfs4_sessionid *sid)
 {
        if (!session)
-               return 0;
+               return false;
        return !memcmp(sid, &session->se_sessionid, sizeof(*sid));
 }