perf hists browser: Do not exit when 'f' is pressed in 'report' mode
authorArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 19 Jun 2015 19:59:43 +0000 (16:59 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 19 Jun 2015 19:59:43 +0000 (16:59 -0300)
The 'f' hotkey is only used when in 'top', dynamic mode, to
enable/disable events, currently not making sense in the 'report',
static mode, where we can't go from showing the histogram entries
created from a perf.data file to adding more events after recreating the
evlist created from the perf.data file, albeit possible, this is not
implemented right now.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Stephane Eranian <eranian@google.com>
Link: http://lkml.kernel.org/n/tip-lholzf472pu98dkkijggwx2m@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/ui/browsers/hists.c

index 764f7cabd6f287d0b4a93d7cf7005fa436081a93..79a093a7d221da9401a276180393da98eff7e063 100644 (file)
@@ -1901,7 +1901,10 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
                        /* Fall thru */
                case 'q':
                case CTRL('c'):
+                       goto out_free_stack;
                case 'f':
+                       if (is_report_browser(hbt))
+                               continue;
                        goto out_free_stack;
                default:
                        continue;