dm: fix missed error code if .end_io isn't implemented by target_type
authorzhendong chen <alex.chen@huawei.com>
Wed, 17 Dec 2014 06:37:04 +0000 (14:37 +0800)
committerMike Snitzer <snitzer@redhat.com>
Wed, 17 Dec 2014 17:31:13 +0000 (12:31 -0500)
In bio-based DM's clone_endio(), when target_type doesn't implement
.end_io (e.g. linear) r will be always be initialized 0.  So if a
WRITE SAME bio fails WRITE SAME will not be disabled as intended.

Fix this by initializing r to error, rather than 0, in clone_endio().

Signed-off-by: Alex Chen <alex.chen@huawei.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Fixes: 7eee4ae2db ("dm: disable WRITE SAME if it fails")
Cc: stable@vger.kernel.org
drivers/md/dm.c

index 4c06585bf1657b076835c073f973b1dc780968d6..b98cd9d84435fe15ea1cb202850508f83b83204b 100644 (file)
@@ -899,7 +899,7 @@ static void disable_write_same(struct mapped_device *md)
 
 static void clone_endio(struct bio *bio, int error)
 {
-       int r = 0;
+       int r = error;
        struct dm_target_io *tio = container_of(bio, struct dm_target_io, clone);
        struct dm_io *io = tio->io;
        struct mapped_device *md = tio->io->md;