mm/page-writeback.c: make changes of dirty_writeback_centisecs take effect immediately

This patch is the followup of the prvious patch:
[writeback: schedule periodic writeback with sysctl].

There's another issue to fix.
For example,
- When the tunable was set to one hour and is reset to one second, the
  new setting will not take effect for up to one hour.

Kicking the flusher threads immediately fixes it.

Cc: Jens Axboe <axboe@kernel.dk>
Cc: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 622a18c114caaf1f3dda16d9b6b2dbf9a49f862e..c518c845f202591cfa1fb8da83a38d6fd256be7b 100644 (file)
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -1976,7 +1976,16 @@ int dirty_writeback_centisecs_handler(struct ctl_table *table, int write,
        int ret;
 
        ret = proc_dointvec(table, write, buffer, length, ppos);
-       if (!ret && !old_interval && dirty_writeback_interval)
+
+       /*
+        * Writing 0 to dirty_writeback_interval will disable periodic writeback
+        * and a different non-zero value will wakeup the writeback threads.
+        * wb_wakeup_delayed() would be more appropriate, but it's a pain to
+        * iterate over all bdis and wbs.
+        * The reason we do this is to make the change take effect immediately.
+        */
+       if (!ret && write && dirty_writeback_interval &&
+               dirty_writeback_interval != old_interval)
                wakeup_flusher_threads(WB_REASON_PERIODIC);
 
        return ret;