[media] em28xx: rename isoc packet number constants and parameters

Rename EM28XX_NUM_PACKETS to EM28XX_NUM_ISOC_PACKETS and
EM28XX_DVB_MAX_PACKETS to EM28XX_DVB_NUM_ISOC_PACKETS to
clarify that these values are used only for isoc usb transfers.
Also use the term num_packets instead of max_packets, as this
is how these values are used and called in struct urb.

Signed-off-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b/drivers/media/usb/em28xx/em28xx-cards.c
index 619bffbab3bc050f2cb2f1f1929bd5da1bdd91a8..7cd2faf610b985a08bf12033cbbde51f11e1bcbe 100644 (file)
--- a/drivers/media/usb/em28xx/em28xx-cards.c
+++ b/drivers/media/usb/em28xx/em28xx-cards.c
@@ -3323,7 +3323,7 @@ static int em28xx_usb_probe(struct usb_interface *interface,
        if (has_dvb) {
                /* pre-allocate DVB isoc transfer buffers */
                retval = em28xx_alloc_isoc(dev, EM28XX_DIGITAL_MODE,
-                                          EM28XX_DVB_MAX_PACKETS,
+                                          EM28XX_DVB_NUM_ISOC_PACKETS,
                                           EM28XX_DVB_NUM_BUFS,
                                           dev->dvb_max_pkt_size);
                if (retval) {

diff --git a/drivers/media/usb/em28xx/em28xx-core.c b/drivers/media/usb/em28xx/em28xx-core.c
index bed07a6c33f8156df80919725c05857cd0fd9b37..2520a164bfa9d47204a7f76de2a558791a23acf6 100644 (file)
--- a/drivers/media/usb/em28xx/em28xx-core.c
+++ b/drivers/media/usb/em28xx/em28xx-core.c
@@ -1034,7 +1034,7 @@ EXPORT_SYMBOL_GPL(em28xx_stop_urbs);
  * Allocate URBs
  */
 int em28xx_alloc_isoc(struct em28xx *dev, enum em28xx_mode mode,
-                     int max_packets, int num_bufs, int max_pkt_size)
+                     int num_packets, int num_bufs, int max_pkt_size)
 {
        struct em28xx_usb_isoc_bufs *isoc_bufs;
        int i;
@@ -1069,7 +1069,7 @@ int em28xx_alloc_isoc(struct em28xx *dev, enum em28xx_mode mode,
        }
 
        isoc_bufs->max_pkt_size = max_pkt_size;
-       isoc_bufs->num_packets = max_packets;
+       isoc_bufs->num_packets = num_packets;
        dev->isoc_ctl.vid_buf = NULL;
        dev->isoc_ctl.vbi_buf = NULL;
 
@@ -1129,7 +1129,7 @@ EXPORT_SYMBOL_GPL(em28xx_alloc_isoc);
  * Allocate URBs and start IRQ
  */
 int em28xx_init_isoc(struct em28xx *dev, enum em28xx_mode mode,
-                    int max_packets, int num_bufs, int max_pkt_size,
+                    int num_packets, int num_bufs, int max_pkt_size,
                     int (*isoc_copy) (struct em28xx *dev, struct urb *urb))
 {
        struct em28xx_dmaqueue *dma_q = &dev->vidq;
@@ -1153,7 +1153,7 @@ int em28xx_init_isoc(struct em28xx *dev, enum em28xx_mode mode,
        }
 
        if (alloc) {
-               rc = em28xx_alloc_isoc(dev, mode, max_packets,
+               rc = em28xx_alloc_isoc(dev, mode, num_packets,
                                       num_bufs, max_pkt_size);
                if (rc)
                        return rc;

diff --git a/drivers/media/usb/em28xx/em28xx-dvb.c b/drivers/media/usb/em28xx/em28xx-dvb.c
index e8008810b60c3ce116c42b499b6506c321c70416..581578f391339264d398997def8daf9d238df2aa 100644 (file)
--- a/drivers/media/usb/em28xx/em28xx-dvb.c
+++ b/drivers/media/usb/em28xx/em28xx-dvb.c
@@ -173,11 +173,12 @@ static int em28xx_start_streaming(struct em28xx_dvb *dvb)
                return max_dvb_packet_size;
        dprintk(1, "Using %d buffers each with %d x %d bytes\n",
                EM28XX_DVB_NUM_BUFS,
-               EM28XX_DVB_MAX_PACKETS,
+               EM28XX_DVB_NUM_ISOC_PACKETS,
                max_dvb_packet_size);
 
        return em28xx_init_isoc(dev, EM28XX_DIGITAL_MODE,
-                               EM28XX_DVB_MAX_PACKETS, EM28XX_DVB_NUM_BUFS,
+                               EM28XX_DVB_NUM_ISOC_PACKETS,
+                               EM28XX_DVB_NUM_BUFS,
                                max_dvb_packet_size, em28xx_dvb_isoc_copy);
 }
 

diff --git a/drivers/media/usb/em28xx/em28xx-video.c b/drivers/media/usb/em28xx/em28xx-video.c
index 202e00bb2b6ed857e66f65129f7948170c88fa8f..94b51da01af0ee288c3aaaebb0232e7029c76aec 100644 (file)
--- a/drivers/media/usb/em28xx/em28xx-video.c
+++ b/drivers/media/usb/em28xx/em28xx-video.c
@@ -764,13 +764,13 @@ buffer_prepare(struct videobuf_queue *vq, struct videobuf_buffer *vb,
        if (urb_init) {
                if (em28xx_vbi_supported(dev) == 1)
                        rc = em28xx_init_isoc(dev, EM28XX_ANALOG_MODE,
-                                             EM28XX_NUM_PACKETS,
+                                             EM28XX_NUM_ISOC_PACKETS,
                                              EM28XX_NUM_BUFS,
                                              dev->max_pkt_size,
                                              em28xx_isoc_copy_vbi);
                else
                        rc = em28xx_init_isoc(dev, EM28XX_ANALOG_MODE,
-                                             EM28XX_NUM_PACKETS,
+                                             EM28XX_NUM_ISOC_PACKETS,
                                              EM28XX_NUM_BUFS,
                                              dev->max_pkt_size,
                                              em28xx_isoc_copy);

diff --git a/drivers/media/usb/em28xx/em28xx.h b/drivers/media/usb/em28xx/em28xx.h
index ad9eec0632754213ea6e1155fa9723569b1be3fd..36a786460e180ed739881e2a2d7434dfc387c8ad 100644 (file)
--- a/drivers/media/usb/em28xx/em28xx.h
+++ b/drivers/media/usb/em28xx/em28xx.h
@@ -157,12 +157,12 @@
 #define EM28XX_NUM_BUFS 5
 #define EM28XX_DVB_NUM_BUFS 5
 
-/* number of packets for each buffer
+/* isoc transfers: number of packets for each buffer
    windows requests only 64 packets .. so we better do the same
    this is what I found out for all alternate numbers there!
  */
-#define EM28XX_NUM_PACKETS 64
-#define EM28XX_DVB_MAX_PACKETS 64
+#define EM28XX_NUM_ISOC_PACKETS 64
+#define EM28XX_DVB_NUM_ISOC_PACKETS 64
 
 #define EM28XX_INTERLACED_DEFAULT 1
 
@@ -667,9 +667,9 @@ int em28xx_set_outfmt(struct em28xx *dev);
 int em28xx_resolution_set(struct em28xx *dev);
 int em28xx_set_alternate(struct em28xx *dev);
 int em28xx_alloc_isoc(struct em28xx *dev, enum em28xx_mode mode,
-                     int max_packets, int num_bufs, int max_pkt_size);
+                     int num_packets, int num_bufs, int max_pkt_size);
 int em28xx_init_isoc(struct em28xx *dev, enum em28xx_mode mode,
-                    int max_packets, int num_bufs, int max_pkt_size,
+                    int num_packets, int num_bufs, int max_pkt_size,
                     int (*isoc_copy) (struct em28xx *dev, struct urb *urb));
 void em28xx_uninit_isoc(struct em28xx *dev, enum em28xx_mode mode);
 void em28xx_stop_urbs(struct em28xx *dev);