ath9k: optimize the usage of power save wrappers.
authorSenthil Balasubramanian <senthilkumar@atheros.com>
Fri, 22 Apr 2011 06:02:10 +0000 (11:32 +0530)
committerJohn W. Linville <linville@tuxdriver.com>
Mon, 25 Apr 2011 18:50:18 +0000 (14:50 -0400)
We need not wake up the chip even before mutex lock is acquired and also
that it is required only if we are going to drain the txq. So place the
wrappers accordingly and this change is also useful when there are no
pending frames in the txq as we do not wake up the chip unnecessarily.

Signed-off-by: Senthil Balasubramanian <senthilkumar@atheros.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath/ath9k/main.c

index e7d6d98ed1ccb5e214df503100cd80959fe3566e..dd2fffbbef2eb710e98d1d6c2597dc6c549d6808 100644 (file)
@@ -2211,9 +2211,7 @@ static void ath9k_flush(struct ieee80211_hw *hw, bool drop)
        int timeout = 200; /* ms */
        int i, j;
 
-       ath9k_ps_wakeup(sc);
        mutex_lock(&sc->mutex);
-
        cancel_delayed_work_sync(&sc->tx_complete_work);
 
        if (drop)
@@ -2236,15 +2234,15 @@ static void ath9k_flush(struct ieee80211_hw *hw, bool drop)
                    goto out;
        }
 
+       ath9k_ps_wakeup(sc);
        if (!ath_drain_all_txq(sc, false))
                ath_reset(sc, false);
-
+       ath9k_ps_restore(sc);
        ieee80211_wake_queues(hw);
 
 out:
        ieee80211_queue_delayed_work(hw, &sc->tx_complete_work, 0);
        mutex_unlock(&sc->mutex);
-       ath9k_ps_restore(sc);
 }
 
 static bool ath9k_tx_frames_pending(struct ieee80211_hw *hw)