drm/amd/display: Fix memory leak in post_update_surfaces

Signed-off-by: Harry Wentland <harry.wentland@amd.com>
Acked-by: Harry Wentland <Harry.Wentland@amd.com>
Reviewed-by: Tony Cheng <Tony.Cheng@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
index 64b5216fb920aeb61b48a11247e67dec76e2df25..b1f0a50171afa6a4d8e37f90e49908663aefdf5d 100644 (file)
--- a/drivers/gpu/drm/amd/display/dc/core/dc.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
@@ -918,6 +918,7 @@ bool dc_post_update_surfaces_to_stream(struct dc *dc)
        int i;
        struct core_dc *core_dc = DC_TO_CORE(dc);
        struct validate_context *context = dm_alloc(sizeof(struct validate_context));
+       bool result = true;
 
        if (!context) {
                dm_error("%s: failed to create validate ctx\n", __func__);
@@ -935,17 +936,19 @@ bool dc_post_update_surfaces_to_stream(struct dc *dc)
 
        if (!core_dc->res_pool->funcs->validate_bandwidth(core_dc, context)) {
                BREAK_TO_DEBUGGER();
-               return false;
+               result = false;
+               goto cleanup;
        }
 
        core_dc->hwss.set_bandwidth(core_dc, context, true);
 
        dc_resource_validate_ctx_copy_construct(context, core_dc->current_context);
 
+cleanup:
        dc_resource_validate_ctx_destruct(context);
        dm_free(context);
 
-       return true;
+       return result;
 }
 
 bool dc_commit_surfaces_to_stream(