ath5k: read sc->imask with sc->irqlock held
authorPavel Roskin <proski@gnu.org>
Thu, 7 Jul 2011 22:14:25 +0000 (18:14 -0400)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 8 Jul 2011 15:47:14 +0000 (11:47 -0400)
Signed-off-by: Pavel Roskin <proski@gnu.org>
sc->imask may change if ath5k_set_current_imask() races against itself.
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath/ath5k/base.c

index 58997d3abae6ad58d5a922dc7bb4b140633e10f5..28113e023c62c32ab81edc6f872b0c5a0c76e447 100644 (file)
@@ -1447,10 +1447,11 @@ ath5k_receive_frame_ok(struct ath5k_softc *sc, struct ath5k_rx_status *rs)
 static void
 ath5k_set_current_imask(struct ath5k_softc *sc)
 {
-       enum ath5k_int imask = sc->imask;
+       enum ath5k_int imask;
        unsigned long flags;
 
        spin_lock_irqsave(&sc->irqlock, flags);
+       imask = sc->imask;
        if (sc->rx_pending)
                imask &= ~AR5K_INT_RX_ALL;
        if (sc->tx_pending)