[PATCH] dvb: dst: remove redundant checksum calculation
authorPerceval Anichini <perceval.anichini@streamvision.fr>
Wed, 9 Nov 2005 05:35:23 +0000 (21:35 -0800)
committerLinus Torvalds <torvalds@g5.osdl.org>
Wed, 9 Nov 2005 15:56:02 +0000 (07:56 -0800)
removes the redundant checksum calculation, which was also exported from the
dst.c module

Signed-off-by: Perceval Anichini <perceval.anichini@streamvision.fr>
Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Cc: Johannes Stezenbach <js@linuxtv.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
drivers/media/dvb/bt8xx/dst_ca.c

index f77fda77b638c12905d59586f7f1451d22a4ea66..16645e06dea22d9e7d5b4e30ed207c0c572198db 100644 (file)
@@ -69,26 +69,12 @@ static int ca_set_pid(void)
 }
 
 
-static int put_checksum(u8 *check_string, int length)
+static void put_checksum(u8 *check_string, int length)
 {
-       u8 i = 0, checksum = 0;
-
-       dprintk(verbose, DST_CA_DEBUG, 1, " ========================= Checksum calculation ===========================");
-       dprintk(verbose, DST_CA_DEBUG, 1, " String Length=[0x%02x]", length);
-       dprintk(verbose, DST_CA_DEBUG, 1, " String=[");
-
-       while (i < length) {
-               dprintk(verbose, DST_CA_DEBUG, 0, " %02x", check_string[i]);
-               checksum += check_string[i];
-               i++;
-       }
-       dprintk(verbose, DST_CA_DEBUG, 0, " ]\n");
-       dprintk(verbose, DST_CA_DEBUG, 1, "Sum=[%02x]\n", checksum);
-       check_string[length] = ~checksum + 1;
-       dprintk(verbose, DST_CA_DEBUG, 1, " Checksum=[%02x]", check_string[length]);
-       dprintk(verbose, DST_CA_DEBUG, 1, " ==========================================================================");
-
-       return 0;
+       dprintk(verbose, DST_CA_DEBUG, 1, " Computing string checksum.");
+       dprintk(verbose, DST_CA_DEBUG, 1, "  -> string length : 0x%02x", length);
+       check_string[length] = dst_check_sum (check_string, length);
+       dprintk(verbose, DST_CA_DEBUG, 1, "  -> checksum      : 0x%02x", check_string[length]);
 }
 
 static int dst_ci_command(struct dst_state* state, u8 * data, u8 *ca_string, u8 len, int read)