wireless, mwifiex: drop redundant NULL test before call to release_firmware()
authorJesper Juhl <jj@chaosbits.net>
Mon, 9 Apr 2012 20:51:12 +0000 (22:51 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Thu, 12 Apr 2012 19:06:07 +0000 (15:06 -0400)
Since release_firmware() does its own test for NULL it is redundant to
do so before calling it.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Bing Zhao <bzhao@marvell.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/mwifiex/main.c

index 9d1b3ca6334b70a827cb047a0a4b2bb54378a0ec..2ee61626c54d58b673e18efcb10128009a0d203e 100644 (file)
@@ -342,8 +342,7 @@ static int mwifiex_init_hw_fw(struct mwifiex_adapter *adapter)
        ret = 0;
 
 done:
-       if (adapter->firmware)
-               release_firmware(adapter->firmware);
+       release_firmware(adapter->firmware);
        if (ret)
                ret = -1;
        return ret;