ACPI / PMIC: Implement exec_mipi_pmic_seq_element for CHT Whiskey Cove PMIC
authorHans de Goede <hdegoede@redhat.com>
Mon, 7 Jan 2019 11:15:54 +0000 (12:15 +0100)
committerHans de Goede <hdegoede@redhat.com>
Wed, 9 Jan 2019 09:35:03 +0000 (10:35 +0100)
Implement the exec_mipi_pmic_seq_element callback for the CHT Whiskey Cove
PMIC.

On some CHT devices this fixes the LCD panel not lighting up when it was
not initialized by the GOP, because an external monitor was plugged in and
the GOP initialized only the external monitor.

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190107111556.4510-3-hdegoede@redhat.com
drivers/acpi/pmic/intel_pmic_chtwc.c

index 078b0448f30a001f90dbc62deb63eafebb78a1ec..7ffd5624b8e15f9734aa3f301e4a3136a8633887 100644 (file)
@@ -231,6 +231,24 @@ static int intel_cht_wc_pmic_update_power(struct regmap *regmap, int reg,
        return regmap_update_bits(regmap, reg, bitmask, on ? 1 : 0);
 }
 
+static int intel_cht_wc_exec_mipi_pmic_seq_element(struct regmap *regmap,
+                                                  u16 i2c_client_address,
+                                                  u32 reg_address,
+                                                  u32 value, u32 mask)
+{
+       u32 address;
+
+       if (i2c_client_address > 0xff || reg_address > 0xff) {
+               pr_warn("%s warning addresses too big client 0x%x reg 0x%x\n",
+                       __func__, i2c_client_address, reg_address);
+               return -ERANGE;
+       }
+
+       address = (i2c_client_address << 8) | reg_address;
+
+       return regmap_update_bits(regmap, address, mask, value);
+}
+
 /*
  * The thermal table and ops are empty, we do not support the Thermal opregion
  * (DPTF) due to lacking documentation.
@@ -238,6 +256,7 @@ static int intel_cht_wc_pmic_update_power(struct regmap *regmap, int reg,
 static struct intel_pmic_opregion_data intel_cht_wc_pmic_opregion_data = {
        .get_power              = intel_cht_wc_pmic_get_power,
        .update_power           = intel_cht_wc_pmic_update_power,
+       .exec_mipi_pmic_seq_element = intel_cht_wc_exec_mipi_pmic_seq_element,
        .power_table            = power_table,
        .power_table_count      = ARRAY_SIZE(power_table),
 };