mlxsw: core: remove unnecessary function mlxsw_core_driver_put
authorYueHaibing <yuehaibing@huawei.com>
Fri, 10 Aug 2018 02:37:30 +0000 (10:37 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 10 Aug 2018 21:40:57 +0000 (14:40 -0700)
The function mlxsw_core_driver_put only traverse mlxsw_core_driver_list
to find the matched mlxsw_driver,but never used it.
So it can be removed safely.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/core.c

index b5d5e57f1583651fcf0ada0d632fa30c0706feba..81533d7f395c14b4e200df93785acdd45ed89c90 100644 (file)
@@ -726,15 +726,6 @@ static struct mlxsw_driver *mlxsw_core_driver_get(const char *kind)
        return mlxsw_driver;
 }
 
-static void mlxsw_core_driver_put(const char *kind)
-{
-       struct mlxsw_driver *mlxsw_driver;
-
-       spin_lock(&mlxsw_core_driver_list_lock);
-       mlxsw_driver = __driver_find(kind);
-       spin_unlock(&mlxsw_core_driver_list_lock);
-}
-
 static int mlxsw_devlink_port_split(struct devlink *devlink,
                                    unsigned int port_index,
                                    unsigned int count,
@@ -1082,7 +1073,6 @@ err_bus_init:
        if (!reload)
                devlink_free(devlink);
 err_devlink_alloc:
-       mlxsw_core_driver_put(device_kind);
        return err;
 }
 EXPORT_SYMBOL(mlxsw_core_bus_device_register);
@@ -1090,7 +1080,6 @@ EXPORT_SYMBOL(mlxsw_core_bus_device_register);
 void mlxsw_core_bus_device_unregister(struct mlxsw_core *mlxsw_core,
                                      bool reload)
 {
-       const char *device_kind = mlxsw_core->bus_info->device_kind;
        struct devlink *devlink = priv_to_devlink(mlxsw_core);
 
        if (mlxsw_core->reload_fail)
@@ -1111,7 +1100,6 @@ void mlxsw_core_bus_device_unregister(struct mlxsw_core *mlxsw_core,
                return;
 reload_fail:
        devlink_free(devlink);
-       mlxsw_core_driver_put(device_kind);
 }
 EXPORT_SYMBOL(mlxsw_core_bus_device_unregister);