staging: vc04_services: Remove VCHIQ_SET_SERVICE_OPTION_T typedef
authorDominic Braun <inf.braun@fau.de>
Fri, 14 Dec 2018 12:05:04 +0000 (13:05 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 17 Dec 2018 13:47:44 +0000 (14:47 +0100)
Typedefing structs is not encouraged in the kernel.

Signed-off-by: Dominic Braun <inf.braun@fau.de>
Signed-off-by: Tobias Büttner <tobias.buettner@fau.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h

index 4a5642b76112df23a1d7e5e55c42a50c9e620c82..95b7d47151105980c5fe2335a2e2ab81f6026c97 100644 (file)
@@ -1428,7 +1428,7 @@ vchiq_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
        } break;
 
        case VCHIQ_IOC_SET_SERVICE_OPTION: {
-               VCHIQ_SET_SERVICE_OPTION_T args;
+               struct vchiq_set_service_option args;
 
                if (copy_from_user(
                        &args, (const void __user *)arg,
index 80c246c033b2b92132e0c3264c95345b3fd0a76c..56aef490e870b7e2c0b0236497b94ae865308c84 100644 (file)
@@ -88,11 +88,11 @@ struct vchiq_get_config {
        struct vchiq_config __user *pconfig;
 };
 
-typedef struct {
+struct vchiq_set_service_option {
        unsigned int handle;
        VCHIQ_SERVICE_OPTION_T option;
        int value;
-} VCHIQ_SET_SERVICE_OPTION_T;
+};
 
 struct vchiq_dump_mem {
        void     *virt_addr;
@@ -121,7 +121,7 @@ struct vchiq_dump_mem {
 #define VCHIQ_IOC_USE_SERVICE          _IO(VCHIQ_IOC_MAGIC,   12)
 #define VCHIQ_IOC_RELEASE_SERVICE      _IO(VCHIQ_IOC_MAGIC,   13)
 #define VCHIQ_IOC_SET_SERVICE_OPTION \
-       _IOW(VCHIQ_IOC_MAGIC,  14, VCHIQ_SET_SERVICE_OPTION_T)
+       _IOW(VCHIQ_IOC_MAGIC,  14, struct vchiq_set_service_option)
 #define VCHIQ_IOC_DUMP_PHYS_MEM \
        _IOW(VCHIQ_IOC_MAGIC,  15, struct vchiq_dump_mem)
 #define VCHIQ_IOC_LIB_VERSION          _IO(VCHIQ_IOC_MAGIC,   16)