[SCSI] be2iscsi: fix lock imbalance
authorJiri Slaby <jslaby@suse.cz>
Tue, 16 Mar 2010 15:23:57 +0000 (16:23 +0100)
committerJames Bottomley <James.Bottomley@suse.de>
Thu, 8 Apr 2010 22:41:50 +0000 (18:41 -0400)
Stanse found that one error path in mgmt_invalidate_icds omits to unlock
ctrl->mbox_lock. Fix that.

Added in 756d29c8c7ed8887ed7d752371ce2f (Enable async mode for mcc rings)
where the spinlock was moved.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Acked-by: Jayamohan Kallickal <jayamohank@serverengines.com>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/be2iscsi/be_mgmt.c

index 72617b650a7e5f8ea28c983f9809612ab9cfccee..e641922f20bc5eb58a4ce0adb879b55e55cad13d 100644 (file)
@@ -169,6 +169,7 @@ unsigned char mgmt_invalidate_icds(struct beiscsi_hba *phba,
                SE_DEBUG(DBG_LVL_1,
                         "Failed to allocate memory for"
                         "mgmt_invalidate_icds \n");
+               spin_unlock(&ctrl->mbox_lock);
                return -1;
        }
        nonemb_cmd.size = sizeof(struct invalidate_commands_params_in);