ASoC: dapm: Don't force card bias level to be updated
authorMark Brown <broonie@opensource.wolfsonmicro.com>
Thu, 23 Aug 2012 17:20:49 +0000 (18:20 +0100)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Sat, 25 Aug 2012 12:51:09 +0000 (13:51 +0100)
Commit 412312 (ASoC: dapm: Make sure all dapm contexts are updated) means
that any DAPM context being updated will have the bias level automatically
set, including the card. We can't safely do this as the card callbacks are
called for each device context and so the management of the card bias is
more complex. Several multi-component cards rely on this behaviour.

Skip updates during the asynchronous run entirely. We should really do them
in the synchronous section but it's not 100% clear which values to pick as
the different DAPM contexts may have different bias levels.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
sound/soc/soc-dapm.c

index 145ec4b56ca9e1891d3835a64c2e249168aaa6ca..f90139b5f50d74089dc98fd0d19de42cb3732a84 100644 (file)
@@ -293,8 +293,9 @@ static int snd_soc_dapm_set_bias_level(struct snd_soc_dapm_context *dapm,
                                                                  level);
                else
                        dapm->bias_level = level;
-       } else
+       } else if (!card || dapm != &card->dapm) {
                dapm->bias_level = level;
+       }
 
        if (ret != 0)
                goto out;