mm/kmemleak.c: change error at _write when kmemleak is disabled
authorAndré Almeida <andrealmeid@collabora.com>
Fri, 12 Jul 2019 03:53:43 +0000 (20:53 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 12 Jul 2019 18:05:42 +0000 (11:05 -0700)
According to POSIX, EBUSY means that the "device or resource is busy", and
this can lead to people thinking that the file
`/sys/kernel/debug/kmemleak/` is somehow locked or being used by other
process.  Change this error code to a more appropriate one.

Link: http://lkml.kernel.org/r/20190612155231.19448-1-andrealmeid@collabora.com
Signed-off-by: André Almeida <andrealmeid@collabora.com>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/kmemleak.c

index 3e147ea831826df1bf6024fdb53157606b6c15ae..aa8f4fa93ca39e6ba5b6be445cb7de1dee953f9b 100644 (file)
@@ -1866,7 +1866,7 @@ static ssize_t kmemleak_write(struct file *file, const char __user *user_buf,
        }
 
        if (!kmemleak_enabled) {
-               ret = -EBUSY;
+               ret = -EPERM;
                goto out;
        }