staging: rtl8712: mlme_linux: Clean up tests if NULL returned on failure
authorBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Tue, 22 Mar 2016 14:59:13 +0000 (20:29 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 28 Mar 2016 14:30:36 +0000 (07:30 -0700)
Some functions like kzalloc return NULL on failure.
When NULL represents failure, !x is commonly used.

This was done using Coccinelle:

@@
expression *e;
identifier l1;
@@

e = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\)(...);
...
- e == NULL
+ !e

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8712/mlme_linux.c

index e4e4bdee78bed7b0aa375eabb6e2d07fc3b96fb2..af7c4a47738ab217b75d130e2a2b9ec70e5b81fc 100644 (file)
@@ -153,7 +153,7 @@ void r8712_report_sec_ie(struct _adapter *adapter, u8 authmode, u8 *sec_ie)
        buff = NULL;
        if (authmode == _WPA_IE_ID_) {
                buff = kzalloc(IW_CUSTOM_MAX, GFP_ATOMIC);
-               if (buff == NULL)
+               if (!buff)
                        return;
                p = buff;
                p += sprintf(p, "ASSOCINFO(ReqIEs=");