sctp: only copy the available addr data in sctp_transport_init

'addr' passed to sctp_transport_init is not always a whole size
of union sctp_addr, like the path:

  sctp_sendmsg() ->
  sctp_sendmsg_new_asoc() ->
  sctp_assoc_add_peer() ->
  sctp_transport_new() -> sctp_transport_init()

In the next patches, we will also pass the address length of data
only to sctp_assoc_add_peer().

So sctp_transport_init() should copy the only available data from
addr to peer->ipaddr, instead of 'peer->ipaddr = *addr' which may
cause slab-out-of-bounds.

Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/sctp/transport.c b/net/sctp/transport.c
index e2f8e369cd08d3cd3395d270cdac7e9c21f70c4d..7235a60326712186060ffc918b8cd14c596c2a3c 100644 (file)
--- a/net/sctp/transport.c
+++ b/net/sctp/transport.c
@@ -43,8 +43,8 @@ static struct sctp_transport *sctp_transport_init(struct net *net,
                                                  gfp_t gfp)
 {
        /* Copy in the address.  */
-       peer->ipaddr = *addr;
        peer->af_specific = sctp_get_af_specific(addr->sa.sa_family);
+       memcpy(&peer->ipaddr, addr, peer->af_specific->sockaddr_len);
        memset(&peer->saddr, 0, sizeof(union sctp_addr));
 
        peer->sack_generation = 0;